Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unsafe_load -> @inbounds codeunit #23582

Merged
merged 1 commit into from
Sep 5, 2017
Merged

unsafe_load -> @inbounds codeunit #23582

merged 1 commit into from
Sep 5, 2017

Conversation

Keno
Copy link
Member

@Keno Keno commented Sep 4, 2017

Addresses post-commit review in #23562.

@Keno
unsafe_load -> @inbounds codeunit
4f8a612 
Addresses post-commit review in #23562.
@Keno
Copy link
Member Author

Keno commented Sep 4, 2017

@nanosoldier runbenchmarks("string")

@ararslan ararslan added the domain:strings "Strings!" label Sep 5, 2017
@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - successfully executed benchmarks. A full report can be found here. cc @ararslan

@Keno
Copy link
Member Author

Keno commented Sep 5, 2017

@nanosoldier runbenchmarks("string", vs = ":master")

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - no performance regressions were detected. A full report can be found here. cc @ararslan

@Keno Keno merged commit 2a133fc into master Sep 5, 2017
@StefanKarpinski StefanKarpinski deleted the kf/codeunit branch September 5, 2017 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

Assignees
No one assigned
Labels
domain:strings "Strings!"
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Keno @nanosoldier @vtjnash @ararslan