Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing datatype_module method for UnionAll types #23496

Merged
merged 1 commit into from
Sep 5, 2017
Merged

Conversation

quinnj
Copy link
Member

@quinnj quinnj commented Aug 29, 2017

No description provided.

@quinnj
Copy link
Member Author

quinnj commented Aug 29, 2017

I don't think I've seen this failure before

	From worker 1:		From worker 1:	Worker 6 failed running test ranges:
Some tests did not pass: 12107327 passed, 1 failed, 0 errored, 327680 broken.ranges: Test Failed
  Expression: cmp_sn2(Tw(xw / yw), astuple(x / y)..., slopbits)
Stacktrace:
 [1] record(::Base.Test.DefaultTestSet, ::Base.Test.Fail) at ./test.jl:651
 [2] (::getfield(Main, Symbol("##40#44")))() at /usr/home/julia/worker/11rel-amd64/build/test/runtests.jl:160
 [3] cd(::getfield(Main, Symbol("##40#44")), ::String) at ./file.jl:70
 [4] include_relative(::Module, ::String) at ./loading.jl:464
 [5] include(::Module, ::String) at ./sysimg.jl:14
 [6] process_options(::Base.JLOptions) at ./client.jl:315
 [7] _start() at ./client.jl:383

Anybody have any concerns w/ this?

@StefanKarpinski
Copy link
Sponsor Member

I'm not sure what problem this is addressing or who should review it.

@quinnj
Copy link
Member Author

quinnj commented Sep 1, 2017

It's just a missing method for UnionAll types, e.g., datatype_name works on both DataType and UnionAll, but datatype_module currently only works on DataType. Hence the PR.

@Keno
Copy link
Member

Keno commented Sep 3, 2017

That test failure is #23497 AFAIK. As for the actual change, LGTM.

@quinnj quinnj merged commit 10ae1b9 into master Sep 5, 2017
@quinnj quinnj deleted the jq/refl branch September 5, 2017 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants