Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: make promote throw an error if no arguments can be changed #23491

Merged
merged 1 commit into from
Aug 31, 2017

Conversation

JeffBezanson
Copy link
Sponsor Member

Fixes #22801.

@JeffBezanson JeffBezanson added the kind:breaking This change will break code label Aug 28, 2017
@ararslan ararslan added the domain:types and dispatch Types, subtyping and method dispatch label Aug 28, 2017
@JeffBezanson JeffBezanson removed the domain:types and dispatch Types, subtyping and method dispatch label Aug 30, 2017
@lostanlen
Copy link

The use of a comma in the NEWS.md entry
"The promote function now raises an error if its arguments are of different types, and attempting to convert them to a common type fails to change any of their types."
changes the logical meaning of the sentence.

I think it would be best to remove the comma and repeat the conjunction "if".
"The promote function now raises an error if its arguments are of different types and if attempting to convert them to a common type fails to change any of their types."

@JeffBezanson
Copy link
Sponsor Member Author

@nanosoldier runbenchmarks(ALL, vs=":master")

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

@JeffBezanson JeffBezanson merged commit 7e35ac6 into master Aug 31, 2017
@JeffBezanson JeffBezanson deleted the jb/noncircular_promote branch August 31, 2017 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:breaking This change will break code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants