Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecations #23440

Merged
merged 1 commit into from
Aug 29, 2017
Merged

Fix deprecations #23440

merged 1 commit into from
Aug 29, 2017

Conversation

femtocleaner[bot]
Copy link
Contributor

@femtocleaner femtocleaner bot commented Aug 24, 2017

I fixed a number of deprecations for you

@vtjnash
Copy link
Member

vtjnash commented Aug 25, 2017

good bot

@StefanKarpinski
Copy link
Member

CI passed (except for Travis, which is, as usual, too slow to be useful). I fixed the merge conflicts.

@StefanKarpinski
Copy link
Member

@musm, I figure you should be aware of this PR.

@musm
Copy link
Contributor

musm commented Aug 25, 2017 •
edited
Loading

Yep I'm aware.
I prefer my two open PR's GMP and MPFR in favor of this however, for some minor items.
For example, the bot does not have this change (it's still a Ptr):
https://github.com/JuliaLang/julia/pull/23289/files#diff-c39f3bbf0cb1c2381243b42647d9ff1dR115
compare to

julia/base/gmp.jl

Line 116 in f173e53

const mpz_t = Ptr{BigInt}

@femtocleaner femtocleaner bot closed this Aug 25, 2017
@femtocleaner
Copy link
Contributor Author

femtocleaner bot commented Aug 25, 2017

My code has been updated and now I don't think there's anything to do here anymore.
Maybe you changed the code, or maybe it's me. Either way, I'll see you next time.

@Keno
Copy link
Member

Keno commented Aug 25, 2017

:O, well, I clearly messed something up here

@Keno Keno reopened this Aug 25, 2017
@femtocleaner femtocleaner bot closed this Aug 25, 2017
@femtocleaner
Copy link
Contributor Author

femtocleaner bot commented Aug 25, 2017

My code has been updated and now I don't think there's anything to do here anymore.
Maybe you changed the code, or maybe it's me. Either way, I'll see you next time.

@Keno Keno reopened this Aug 25, 2017
@Keno
Copy link
Member

Keno commented Aug 25, 2017

Somebody didn't get enough sleep.

@femtocleaner
Copy link
Contributor Author

femtocleaner bot commented Aug 25, 2017

My code has been updated. I now view the world differently.
Am I still the same bot I was before?
In any case, I've updated this PR to reflect my new knowledge. I hope you like it.

Keno
Keno reviewed Aug 25, 2017
View reviewed changes
doc/src/manual/documentation.md Outdated
if VERSION > v"0.5"
"..."
f(x) = x
end
Copy link
Member

@Keno Keno Aug 25, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not correct, but I don't think I can really blame the bot for this. Maybe we can pick a better example in the docs?

Keno
Keno requested changes Aug 25, 2017
View reviewed changes
test/show.jl Outdated
@@ -755,7 +755,7 @@ end

# showing generator and comprehension expressions
@test repr(:(x for x in y for z in w)) == ":((x for x = y for z = w))"
@test repr(:(x for x in y if aa for z in w if bb)) == ":((x for x = y if aa for z = w if bb))"
@test repr(:(x for x i n y if aa for z in w if bb)) == ":((x for x = y if aa for z = w if bb))"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad bot

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry. I'm still new at this 🐒. I'll file an issue about this for you.

@femtocleaner femtocleaner bot mentioned this pull request Aug 25, 2017
Closed
@femtocleaner
Copy link
Contributor Author

femtocleaner bot commented Aug 26, 2017

My code has been updated. I now view the world differently.
Am I still the same bot I was before?
In any case, I've updated this PR to reflect my new knowledge. I hope you like it.

Keno added a commit that referenced this pull request Aug 26, 2017
@Keno
Update conditional documentation example
fd06baa 
It confuses femtocleaner (#23440) and it's probably
better to not reference a specific julia version in the documentation anyway.
@Keno Keno mentioned this pull request Aug 26, 2017
Merged
@femtocleaner
Copy link
Contributor Author

femtocleaner bot commented Aug 28, 2017

My code has been updated. I now view the world differently.
Am I still the same bot I was before?
In any case, I've updated this PR to reflect my new knowledge. I hope you like it.

@StefanKarpinski
Copy link
Member

The bot's PR passed CI, should we merge this now?

@tkelman
Copy link
Contributor

tkelman commented Aug 29, 2017

we haven't verified @nanosoldier runbenchmarks(ALL, vs=":master") yet here right?

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

@Keno
Copy link
Member

Keno commented Aug 29, 2017

Looks fine to me. Most of those are known to be flakey.

@Keno Keno merged commit 9089b13 into master Aug 29, 2017
@ararslan ararslan deleted the fbot/deps branch August 29, 2017 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

@Keno Keno Keno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vtjnash @StefanKarpinski @musm @Keno @tkelman @nanosoldier