Doc merge_analysis and some enums #23435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyatt
added
domain:docs
ararslan
reviewed
Aug 24, 2017
base/libgit2/consts.jl
Outdated
| @enum(GIT_MERGE_PREFERENCE, MERGE_PREFERENCE_NONE = 0, | ||
| MERGE_PREFERENCE_NO_FASTFORWARD = 1, | ||
| MERGE_PREFERENCE_FASTFORWARD_ONLY = 2) | ||
|
|
||
| """ Result of analysis on merge possibilities. | ||
| * `MERGE_ANALYSIS_NONE`: it is not possible to merge the elements of `anns`. |
ararslan
reviewed
Aug 24, 2017
| @@ -93,6 +93,7 @@ Base.LibGit2.lookup_branch | |||
| Base.LibGit2.mirror_callback | |||
| Base.LibGit2.mirror_cb | |||
| Base.LibGit2.message | |||
| Base.LibGit2.merge_analysis | |||
There was a problem hiding this comment.
Maybe add the newly documented enums in here too?
There was a problem hiding this comment.
I don't think we have the other enums in this...
There was a problem hiding this comment.
Seems like we should though, at least IMO.
There was a problem hiding this comment.
See here for a discussion of why we didn't do this
now consistent with the other options
ararslan
approved these changes
Aug 27, 2017
|
Test fail is in unrelated spawn tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.