Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix incorrect static parameter munging as part of inlineable #23274

Merged
merged 2 commits into from
Aug 16, 2017
Merged

fix incorrect static parameter munging as part of inlineable #23274

merged 2 commits into from
Aug 16, 2017

Conversation

jrevels
Copy link
Member

@jrevels jrevels commented Aug 15, 2017

This parameter munging was previously incorrect. Why? Because Jameson said so!

@ararslan ararslan added the compiler:inference Type inference label Aug 15, 2017
@jrevels
Copy link
Member Author

jrevels commented Aug 15, 2017

Hmm...these corrections might be incorrect:

error during bootstrap:
LoadError(at "coreimg.jl" line 3: LoadError(at "inference.jl" line 6092: MethodError(f=typeof(Core.Inference.unsafe_convert)(), args=(Ptr{Any}, svec(Any)), world=0x00000b21)))

cc @vtjnash

@JeffBezanson JeffBezanson merged commit b36fc63 into master Aug 16, 2017
@JeffBezanson JeffBezanson deleted the jr/fixsparamsmunging branch August 16, 2017 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

@JeffBezanson JeffBezanson JeffBezanson approved these changes

Assignees
No one assigned
Labels
compiler:inference Type inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jrevels @vtjnash @JeffBezanson @ararslan