Rename ctranspose to adjoint
#23235
Rename ctranspose to adjoint
#23235
Conversation
andyferris
force-pushed
the
ajf/adjoint
branch
from
bcb056d
to
2c10c9f
Compare
NEWS.md
Outdated
| @@ -309,6 +309,9 @@ Deprecated or removed | |||
| * `Base.cpad` has been removed; use an appropriate combination of `rpad` and `lpad` | |||
| instead ([#23187]). | |||
|
|
|||
| * `ctranspose` and `ctranspose!` have been deprecated in favor of `adjoint` and `adjoint!`, | |||
| respectively. | |||
base/deprecated.jl
Outdated
| @@ -1684,6 +1684,10 @@ end | |||
| # PR #22742: change in isapprox semantics | |||
| @deprecate rtoldefault(x,y) rtoldefault(x,y,0) false | |||
|
|
|||
| # PR #23235 | |||
| @deprecate ctranspose adjoint | |||
| @deprecate ctranspose! adjoint | |||
test/operators.jl
Outdated
| @@ -49,7 +49,7 @@ p = 1=>:foo | |||
| @test xor(2) == 2 | |||
| @test (⊻)(2) == 2 | |||
|
|
|||
| # @test ctranspose('a') == 'a' # (c)transpose of Chars no longer supported | |||
| # @test adjoint('a') == 'a' # (c)transpose of Chars no longer supported | |||
There was a problem hiding this comment.
Perhaps update the comment as well?
There was a problem hiding this comment.
Hmm... I think we can delete this now.
(I have an upcoming PR which will let us transpose arrays of Chars and Strings and so-on, so the context of this whole line will be rather out-of-date.)
Sacha0
added
kind:deprecation
|
Any more comments or any detractors before I merge this? (I just realized we should probably rename |
|
Let's give it a bit more time since this has only been open for half a day on a weekend. I don't imagine there being much controversy here, however. |
|
Something went funky with the linux tests |
|
Restarted them. |
|
Bump – rebase. That Linux issue should be resolved now. |
|
cc @alanedelman |
|
Thanks @andreasnoack (I'm travelling ATM). The test errors appear unrelated and oddly spurious... one inference failure for RowVector and test failure one in codegen, but only on specific builds. |
Just to prove exactly how seriously we take transposes, we need to rename one of them.
Part of #20978. This one was simple find-replace (so far).