Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codegen: fix use-after-free #22993

Merged
merged 1 commit into from
Jul 28, 2017
Merged

codegen: fix use-after-free #22993

merged 1 commit into from
Jul 28, 2017

Conversation

vtjnash
Copy link
Sponsor Member

@vtjnash vtjnash commented Jul 28, 2017

No description provided.

@tkelman tkelman added the needs tests Unit tests are required for this change label Jul 28, 2017
@JeffBezanson
Copy link
Sponsor Member

@tkelman This can't really be tested directly; it's basically asymptomatic unless run under valgrind.

also link to #22973

@vtjnash vtjnash removed the needs tests Unit tests are required for this change label Jul 28, 2017
@vtjnash
Copy link
Sponsor Member Author

vtjnash commented Jul 28, 2017

also should fix #22952

@tkelman
Copy link
Contributor

tkelman commented Jul 28, 2017

or when run with old glibc, does fix 22952 so buildbots would notice if it regressed

@JeffBezanson JeffBezanson merged commit 100a6fc into master Jul 28, 2017
@JeffBezanson JeffBezanson deleted the jn/22973 branch July 28, 2017 15:42
@JeffBezanson JeffBezanson mentioned this pull request Jul 28, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vtjnash @JeffBezanson @tkelman