Remove momenttype and use reduction initialization infrastructure #22937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
added
kind:bugfix
|
This is used in DataArrays and a few other packages and would be safer to deprecate |
tkelman
reviewed
Jul 24, 2017
base/deprecated.jl
Outdated
| @@ -1569,6 +1569,10 @@ end | |||
|
|
|||
| @deprecate String(io::GenericIOBuffer) String(take!(copy(io))) | |||
|
|
|||
| @eval Base begin | |||
There was a problem hiding this comment.
this file is in Base? can set the extra boolean argument to false so it's not exported
andreasnoack
force-pushed
the
anj/anyvar
branch
2 times, most recently
from
80a21b7
to
76bbfc8
Compare
tkelman
reviewed
Jul 25, 2017
base/deprecated.jl
Outdated
| @@ -1591,6 +1591,10 @@ end | |||
| @deprecate readstring(filename::AbstractString) read(filename, String) | |||
| @deprecate readstring(cmd::AbstractCmd) read(cmd, String) | |||
|
|
|||
| @eval Base begin | |||
There was a problem hiding this comment.
this eval shouldn't be needed
for determining the return type. Adjust return type determination in _quantile Fixes #22901
|
Would this fix #21786 ? |
|
It appears so julia> A = fill(1KiloGram, 2, 2)
2×2 Array{SIUnits.SIQuantity{Int64,0,1,0,0,0,0,0,0,0},2}:
1 kg 1 kg
1 kg 1 kg
julia> mean(A, 1)
1×2 Array{SIUnits.SIQuantity{Float64,0,1,0,0,0,0,0,0,0},2}:
1.0 kg 1.0 kg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for determining the return type.
Adjust return type determination in
_quantileFixes #22901