Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JL_ namespace to all header include guards #22904

Merged
merged 2 commits into from
Jul 22, 2017
Merged

Add JL_ namespace to all header include guards #22904

merged 2 commits into from
Jul 22, 2017

Conversation

tkonolige
Copy link
Contributor

@tkonolige tkonolige commented Jul 21, 2017 •
edited
Loading

This pull request addresses the first part of #22887.

@tkelman
Copy link
Contributor

tkelman commented Jul 21, 2017 •
edited
Loading

little bit of a misnomer for the ones from flisp, but otherwise looks okay

Keno
Keno approved these changes Jul 21, 2017
View reviewed changes
Copy link
Member

@Keno Keno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit weird for the header files that already have JULIA in the guard name, but it doesn't really matter. LGTM.

@StefanKarpinski
Copy link
Sponsor Member

Nice. I would replace JL_JULIA_ => JL_ and JL_FLISP_ => FLISP_ and then this is good.

@tkonolige
Copy link
Contributor Author

I changed JL_JULIA_ to JL_ except for julia.h which I left as JULIA_H. I also changed JL_FLISP_ to FLISP_.

@JeffBezanson JeffBezanson mentioned this pull request Jul 21, 2017
Merged
@JeffBezanson JeffBezanson merged commit a627e51 into JuliaLang:master Jul 22, 2017
jeffwong pushed a commit to jeffwong/julia that referenced this pull request Jul 24, 2017
@tkonolige @jeffwong
Add JL_ namespace to all header include guards (JuliaLang#22904)
685caf1 
Add JL_ namespace to all header include guards
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanKarpinski StefanKarpinski StefanKarpinski approved these changes

@JeffBezanson JeffBezanson JeffBezanson approved these changes

@Keno Keno Keno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tkonolige @tkelman @StefanKarpinski @JeffBezanson @Keno