Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify alignment for printing Pair in arrays #22899

Merged
merged 3 commits into from
Jul 27, 2017
Merged

specify alignment for printing Pair in arrays #22899

merged 3 commits into from
Jul 27, 2017

Conversation

rfourquet
Copy link
Member

Before:

julia> [1=>22, 33=>4]
2-element Array{Pair{Int64,Int64},1}:
 1=>22
 33=>4

After:

julia> [1=>22, 33=>4]
2-element Array{Pair{Int64,Int64},1}:
  1=>22
 33=>4

@rfourquet rfourquet added the domain:display and printing Aesthetics and correctness of printed representations of objects. label Jul 21, 2017
@tkelman tkelman added the needs tests Unit tests are required for this change label Jul 21, 2017
@rfourquet rfourquet removed the needs tests Unit tests are required for this change label Jul 21, 2017
@rfourquet rfourquet force-pushed the rf/pair-align branch 3 times, most recently from 71ef770 to 1765862 Compare July 21, 2017 12:05
@StefanKarpinski
Copy link
Sponsor Member

Looks good to me. Should we also print pairs with spaces around the =>, i.e. 1 => 2?

@rfourquet
Copy link
Member Author

Should we also print pairs with spaces around the =>, i.e. 1 => 2

I at least wanted to propose this! I planned to make the non-compact form of pairs show spaces, and to not use compact printing for vectors.

@rfourquet
Copy link
Member Author

The CI failures seem unrelated, but should we restart them?

@rfourquet
Copy link
Member Author

I will merge by tomorrow if no-one objects; this seems to be uncontroversial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:display and printing Aesthetics and correctness of printed representations of objects.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants