deprecation warning for old parametric method syntax. fixes #11310 #22834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
the
kind:deprecation
tkelman
reviewed
Jul 16, 2017
| (syntax-deprecation #f | ||
| (string "inner constructor " name "(...)" (linenode-string lno)) | ||
| (deparse `(where (call (curly ,name ,@params) ...) ,@params))))) | ||
| (syntax-deprecation #f |
There was a problem hiding this comment.
either here on in deprecated.jl, should these be annotated with "remove in version ..." ?
JeffBezanson
force-pushed
the
jb/fix11310-3
branch
from
5776baa
to
2316249
Compare
|
Anybody understand the linux64 failure here? |
|
Seen it once on #22684 last night. No sure what happened and doesn't seem to be clear error message... |
|
Rebased and fixed conflict. We'll see whether the failure shows up again. |
|
Script to automatically fix these: https://discourse.julialang.org/t/psa-parametric-method-syntax-deprecation-about-to-drop/4931/15 Just tried it myself, seems to work well. |
|
Nice! Is this ready to be merged then? AV failure is a timeout. |
martinholters
added a commit
to HSU-ANT/ACME.jl
that referenced
this pull request
Jul 26, 2017
To maintain backward compatibility, parametric function definitions are done using the macro `pfunction`. Function definition that also require at-compat employ a second new macro, `expandafter`, so that Compat sees the generated function defition.
|
Resolved conflicts using web interface, so needs squashing. |
martinholters
added a commit
to HSU-ANT/ACME.jl
that referenced
this pull request
Jul 26, 2017
To maintain backward compatibility, parametric function definitions are done using the macro `pfunction`. Function definitions that also require `compat` employ a second new macro, `expandafter`, so that `compat` sees the generated function definition. Bumps Compat requirement to 0.26.0 because it uses `macroexpand(::Module, ::ANY)`.
|
Oh goody, let's see if I missed any from my pre-emptive strike. |
yuyichao
added a commit
to yuyichao/julia
that referenced
this pull request
Jul 29, 2017
…uliaLang#11310 (JuliaLang#22834)" This partially reverts commit c6e51d0.
yuyichao
added a commit
to yuyichao/julia
that referenced
this pull request
Sep 17, 2017
…uliaLang#11310 (JuliaLang#22834)" This partially reverts commit c6e51d0.
yuyichao
added a commit
to yuyichao/julia
that referenced
this pull request
Sep 19, 2017
…uliaLang#11310 (JuliaLang#22834)" This partially reverts commit c6e51d0.
yuyichao
added a commit
to yuyichao/julia
that referenced
this pull request
Sep 26, 2017
…uliaLang#11310 (JuliaLang#22834)" This partially reverts commit c6e51d0.
yuyichao
added a commit
to yuyichao/julia
that referenced
this pull request
Sep 27, 2017
…uliaLang#11310 (JuliaLang#22834)" This partially reverts commit c6e51d0.
yuyichao
added a commit
to yuyichao/julia
that referenced
this pull request
Sep 27, 2017
…uliaLang#11310 (JuliaLang#22834)" This partially reverts commit c6e51d0.
yuyichao
added a commit
to yuyichao/julia
that referenced
this pull request
Oct 25, 2017
…uliaLang#11310 (JuliaLang#22834)" This partially reverts commit c6e51d0.
yuyichao
added a commit
to yuyichao/julia
that referenced
this pull request
Oct 25, 2017
…uliaLang#11310 (JuliaLang#22834)" This partially reverts commit c6e51d0.
yuyichao
added a commit
to yuyichao/julia
that referenced
this pull request
Oct 26, 2017
…uliaLang#11310 (JuliaLang#22834)" This partially reverts commit c6e51d0.
yuyichao
added a commit
to yuyichao/julia
that referenced
this pull request
Oct 31, 2017
…uliaLang#11310 (JuliaLang#22834)" This partially reverts commit c6e51d0.
yuyichao
added a commit
to yuyichao/julia
that referenced
this pull request
Feb 7, 2018
…uliaLang#11310 (JuliaLang#22834)" This partially reverts commit c6e51d0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK folks, it's time to rip the band-aid off.