Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LU factorization in-place operations #22774

Merged
merged 4 commits into from
Aug 24, 2017
Merged

Fix LU factorization in-place operations #22774

merged 4 commits into from
Aug 24, 2017

Commits on Aug 23, 2017

  1. Add tests for in-place operations of A_ldiv_B!(y, LU, x) for LU facto… 

    …rizations
    @haampie
    haampie committed Aug 23, 2017
    Configuration menu
    Copy the full SHA
    8775d66 View commit details
    Browse the repository at this point in the history

  2. Do Ax_ldiv_B! for LU factorizations in-place

    @haampie
    haampie committed Aug 23, 2017
    Configuration menu
    Copy the full SHA
    d08467c View commit details
    Browse the repository at this point in the history

  3. Remove incorrect condition in LU test. The transpose should be tested… 

    … for complex numbers, and might be skipped for real numbers; not the other way around. For clarity just test both unconditionally.
    @haampie
    haampie committed Aug 23, 2017
    Configuration menu
    Copy the full SHA
    5f2350a View commit details
    Browse the repository at this point in the history

  4. Get rid of allocations, apply the (inverse) permutation in-place

    @haampie
    haampie committed Aug 23, 2017
    Configuration menu
    Copy the full SHA
    944f02a View commit details
    Browse the repository at this point in the history