fix #14182: OS X linker target mismatch warning #22746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihnorton
force-pushed
the
fix_osx_targetwarn
branch
from
ac0b227
to
a39d73d
Compare
ihnorton
changed the title
ararslan
reviewed
Jul 11, 2017
| @@ -1070,6 +1070,7 @@ void jl_dump_native(const char *bc_fname, const char *unopt_bc_fname, const char | |||
| TheTriple.setObjectFormat(Triple::COFF); | |||
| #elif defined(_OS_DARWIN_) | |||
| TheTriple.setObjectFormat(Triple::MachO); | |||
| TheTriple.setOS(llvm::Triple::MacOSX); | |||
There was a problem hiding this comment.
In the off chance that Julia works on PureDarwin (I assume no one has ever tried), perhaps this should be in its own #ifdef __APPLE__?
There was a problem hiding this comment.
same difference
Lines 72 to 73 in 090e549
ararslan
added
domain:building
jeffwong
pushed a commit
to jeffwong/julia
that referenced
this pull request
Jul 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #14182. ref: ldc-developers/ldc#1209