Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize squeeze to work with OffsetArrays #22663

Merged
merged 2 commits into from
Sep 22, 2017
Merged

Generalize squeeze to work with OffsetArrays #22663

merged 2 commits into from
Sep 22, 2017

Conversation

GregPlowman
Copy link
Contributor

Enable squeeze() for arrays with non-standard (not 1-based) indexing, e.g. OffsetArrays.

@ararslan ararslan added the domain:arrays [a, r, r, a, y, s] label Jul 3, 2017
@ararslan ararslan requested a review from timholy July 3, 2017 02:10
@GregPlowman GregPlowman closed this Jul 3, 2017
@GregPlowman GregPlowman reopened this Jul 3, 2017
@GregPlowman
Copy link
Contributor Author

Travis failure looks like i686 timeout

@GregPlowman
Copy link
Contributor Author

Closing and reopening to rerun tests.
Anyone care to review and move this forward?

@GregPlowman GregPlowman reopened this Sep 14, 2017
timholy
timholy approved these changes Sep 15, 2017
View reviewed changes
Copy link
Sponsor Member

@timholy timholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Once Travis finishes with it, let's merge.

@mbauman mbauman merged commit 72eed90 into JuliaLang:master Sep 22, 2017
@mbauman
Copy link
Sponsor Member

mbauman commented Sep 22, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timholy timholy timholy approved these changes

Assignees
No one assigned
Labels
domain:arrays [a, r, r, a, y, s]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GregPlowman @mbauman @timholy @ararslan