Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in buffer handling in readlines() function for \r\n new line type #22621

Merged
merged 1 commit into from
Sep 20, 2017
Merged

Fix bug in buffer handling in readlines() function for \r\n new line type #22621

merged 1 commit into from
Sep 20, 2017

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Jun 29, 2017

This is a fix for #22430.

@bkamins bkamins mentioned this pull request Jul 2, 2017
Closed
@StefanKarpinski StefanKarpinski added domain:io Involving the I/O subsystem: libuv, read, write, etc. kind:bugfix This change fixes an existing bug backport pending 0.6 labels Jul 10, 2017
@vtjnash vtjnash removed the request for review from JeffBezanson September 19, 2017 05:34
vtjnash
vtjnash approved these changes Sep 19, 2017
View reviewed changes
Copy link
Sponsor Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased, just need to check that CI passes still. Sorry for letting this sit for so long. It's a good fix, I had just forgotten about it since Jeff was assigned as the reviewer.

@bkamins
Copy link
Member Author

bkamins commented Sep 19, 2017

@vtjnash Thank you. I believe that the test failures are due to unrelated issues.

@JeffBezanson JeffBezanson merged commit 1c0573e into JuliaLang:master Sep 20, 2017
ararslan pushed a commit that referenced this pull request Nov 7, 2017
@bkamins @ararslan
iostream: Fix \r\n handling in reading buffers (#22621)
c4cc493 
(cherry picked from commit 1c0573e)
ararslan pushed a commit that referenced this pull request Nov 14, 2017
@bkamins @ararslan
iostream: Fix \r\n handling in reading buffers (#22621)
67ea744 
(cherry picked from commit 1c0573e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

Assignees
No one assigned
Labels
domain:io Involving the I/O subsystem: libuv, read, write, etc. kind:bugfix This change fixes an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bkamins @vtjnash @StefanKarpinski @JeffBezanson @ararslan