Add more @test tests

[omus]

Minor follow up to #22558.

I also discovered a small issue when invalid syntax is used when calling isapprox or isequal where a MethodError will be thrown instead of a syntax error:

julia> isequal(; a=1:2...)
ERROR: syntax: splicing with "..." cannot be used for a keyword argument value

julia> @test isequal(; a=1:2...)
Error During Test
  Test threw an exception of type MethodError
  Expression: isequal(; a=1:2...)
  MethodError: no method matching Pair(::Symbol, ::Int64, ::Int64)

Due to the way @test revises the expression so that each argument is evaluated I'm not sure much can be done here without evaluating the original expression and the arguments separately (effectively evaluating the arguments twice). I can open an issue if need be.

[DrKrar]

this and the previous test should be removed as they produce error
syntax: keyword argument "atol" repeated in call to "Base.Test.Expr"

[omus]

Can you give an example where this is giving a syntax error? What version of Julia did you try this on?

julia> using Base.Test

julia> @test isapprox(1, 2, atol=0) atol=1
Test Passed

julia> @test isapprox(1, 3, atol=0; atol=2) atol=1
Test Passed

[Sacha0]

I can reproduce @DrKrar's concern at the REPL

julia> versioninfo()
Julia Version 0.7.0-DEV.703
Commit 4226320 (2017-06-24 18:23 UTC)
Platform Info:
  OS: macOS (x86_64-apple-darwin15.6.0)
  CPU: Intel(R) Core(TM) i7-3520M CPU @ 2.90GHz
  WORD_SIZE: 64
  BLAS: libopenblas (USE64BITINT DYNAMIC_ARCH NO_AFFINITY Sandybridge)
  LAPACK: libopenblas64_
  LIBM: libopenlibm
  LLVM: libLLVM-3.9.1 (ORCJIT, ivybridge)
Environment:
  JULIA_EDITOR = mate

julia> using Base.Test

julia> @test isapprox(1, 2, atol=0) atol=1
ERROR: syntax: keyword argument "atol" repeated in call to "Base.Test.Expr"

julia> @test isapprox(1, 3, atol=0; atol=2) atol=1
ERROR: syntax: keyword argument "atol" repeated in call to "Base.Test.Expr"

Rebuilding master now, will update afterwards.

[Sacha0]

Works on up-to-date master, so chances are @DrKrar's concern applies to a slightly out-of-date build. Best!

julia> versioninfo()
Julia Version 0.7.0-DEV.796
Commit 2c85595 (2017-06-29 16:32 UTC)
Platform Info:
  OS: macOS (x86_64-apple-darwin15.6.0)
  CPU: Intel(R) Core(TM) i7-3520M CPU @ 2.90GHz
  WORD_SIZE: 64
  BLAS: libopenblas (USE64BITINT DYNAMIC_ARCH NO_AFFINITY Sandybridge)
  LAPACK: libopenblas64_
  LIBM: libopenlibm
  LLVM: libLLVM-3.9.1 (ORCJIT, ivybridge)
Environment:
  JULIA_EDITOR = mate

julia> using Base.Test

julia> @test isapprox(1, 2, atol=0) atol=1
Test Passed

julia> @test isapprox(1, 3, atol=0; atol=2) atol=1
Test Passed

[omus]

Gotcha. You definitely need the hot out of the oven 0.7.0-DEV.791 (82df8e7) or above for these tests to work.

[Sacha0]

superficially lgtm! :)

[omus]

Thanks Tony