RFC: add procs argument to @-everywhere and move code to a function #22589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkelman
reviewed
Jun 28, 2017
base/distributed/macros.jl
Outdated
| `@everywhere` with [`@eval`](@ref) allows us to broadcast | ||
| local variables using interpolation : | ||
| `@everywhere` does not capture any local variables. | ||
| Instead, local variable can be broadcast using interpolation: |
tkelman
reviewed
Jun 28, 2017
base/distributed/macros.jl
Outdated
| yield() # ensure that the remotecall_fetch has been started | ||
| remotecall_eval(m::Module, procs, expression) | ||
|
|
||
| Execute an expression under module `m` on all procs. |
c2fda80
to
4187526
Compare
|
this by itself is less controversial than #22588. please decouple them. |
a592f3f
to
f8b84f2
Compare
8225299
to
1e811d9
Compare
tkelman
reviewed
Jul 18, 2017
| unshift!(LOAD_PATH, $load_path) | ||
| unshift!(LOAD_CACHE_PATH, $load_cache_path) | ||
| end) | ||
| @everywhere test_workers begin |
There was a problem hiding this comment.
this is a pretty indirect test, could use something more specific in the distributed tests
adding remotecall_eval lets us simplify code that previously needed awkward contortions to use remotecall_fetch on an anonymous function fixes a code-duplication bug in the case where something is spliced into expr and removes and corrects misleading information in the doc string
1e811d9
to
d1de420
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a function
remotecall_evallets us simplify code that previously needed awkward contortions to useremotecall_fetchon an anonymous function. This allows us to transform the more complex pattern of:into:
@everywhere pids expressionwhich resolves #18166
(note: This is against PR #22588, since I wanted to use this functionality to simplify its tests. When the RFCs are removed, I'll rebase whichever ones we decide to merge first.)