Misc. small libgit2 tests #22483
Merged
Misc. small libgit2 tests #22483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyatt
added
libgit2
omus
reviewed
Jun 22, 2017
| @@ -246,6 +246,8 @@ mktempdir() do dir | |||
| else | |||
| error("Found unexpected entry: $name") | |||
| end | |||
| show_str = sprint(show, entry) | |||
| @test show_str == string("ConfigEntry(\"", name, "\", \"", value, "\")") | |||
There was a problem hiding this comment.
Just a style issue but I find using string interpolation makes things easier to read:
"ConfigEntry(\"$name\", \"$value\")"| creds2 = LibGit2.UserPasswordCredentials(creds_user, creds_pass) | ||
| @test creds == creds2 | ||
| LibGit2.reset!(creds) | ||
| @test !LibGit2.checkused!(creds) |
There was a problem hiding this comment.
I think having the reset! and checkused! moved up to above. Do you want this here to ensure that equality works when the count fields don't match?
There was a problem hiding this comment.
Yeah that was my thought
| sshcreds = LibGit2.SSHCredentials(creds_user, creds_pass) | ||
| @test sshcreds.user == creds_user | ||
| @test sshcreds.pass == creds_pass | ||
| @test isempty(sshcreds.prvkey) | ||
| @test isempty(sshcreds.pubkey) | ||
| sshcreds2 = LibGit2.SSHCredentials(creds_user, creds_pass) | ||
| @test sshcreds == sshcreds2 |
There was a problem hiding this comment.
Up to you but I would probably do:
@test sshcreds == LibGit2.SSHCredentials(creds_user, creds_pass)
|
@omus do you want me to change the equality test for SSHCreds or is this good to go :)? |
|
Sorry, forgot to submit a review. Retroactively LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for:
ConfigEntryheadwhen you pass it a string that's a package location