Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement lufact(A::HermOrSym) #22478

Merged
merged 1 commit into from
Jun 24, 2017

Conversation

fredrikekre
Copy link
Member

This also fixed the following:

julia> A = rand(3, 3); S = Symmetric(A'A); D = Diagonal(rand(3));

julia> S\D
3×3 Array{Float64,2}:
  4.47548    0.58589  -2.70101
  0.799888   2.49059  -1.74015
 -4.00037   -1.88777   3.61472

julia> S\S
3×3 Array{Float64,2}:
 1.0  0.0  0.0
 0.0  1.0  0.0
 0.0  0.0  1.0

but I am not sure this is the correct fix for that so I have not yet included tests for that. The other fix would be to relax the method definition here. Regardless, I think it could be useful to have lufact work for Symmetric/Hermitian. Thoughts?

@kshyatt kshyatt added the domain:linear algebra Linear algebra label Jun 22, 2017
@andreasnoack andreasnoack merged commit c0cea34 into JuliaLang:master Jun 24, 2017
@fredrikekre fredrikekre deleted the fe/lufact-symherm branch June 25, 2017 02:17
@fredrikekre
Copy link
Member Author

Thanks, could you comment on my question in the OP @andreasnoack ? :)

DrTodd13 pushed a commit to IntelLabs/julia that referenced this pull request Jun 26, 2017
@andreasnoack
Copy link
Member

I think it would be fine to relax the other method as well. Would it introduce any ambiguities?

@fredrikekre
Copy link
Member Author

See #22561

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants