Return socket correctly in socket_reuse_port #22017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the problem is #20362 . Appears that failures from tests run under process 1, i.e., |
amitmurthy
force-pushed
the
amitmurthy-patch-1
branch
from
3bfea97
to
1719e14
Compare
amitmurthy
force-pushed
the
amitmurthy-patch-1
branch
from
ecca93a
to
6fa26d1
Compare
|
I am going to be merging this soon. Linux CI passes cleanly though it appears that the Linux version used for CI does not support SO_REUSEPORT. The CI logs print an informational string "INFO: SO_REUSEPORT is unsupported, skipping reuseport tests." if this is the case. Linux kernel 3.9 and later support SO_REUSEPORT |
vtjnash
approved these changes
May 22, 2017
ararslan
pushed a commit
that referenced
this pull request
Sep 11, 2017
ararslan
pushed a commit
that referenced
this pull request
Sep 13, 2017
* Return socket correctly in socket_reuse_port * Run reuseport tests only if SO_REUSEPORT is supported. * Test fix - test for successful addition of workers in distributed test (cherry picked from commit d3bc329)
vtjnash
pushed a commit
that referenced
this pull request
Sep 14, 2017
* Return socket correctly in socket_reuse_port * Run reuseport tests only if SO_REUSEPORT is supported. * Test fix - test for successful addition of workers in distributed test (cherry picked from commit d3bc329)
ararslan
pushed a commit
that referenced
this pull request
Sep 15, 2017
* Return socket correctly in socket_reuse_port * Run reuseport tests only if SO_REUSEPORT is supported. * Test fix - test for successful addition of workers in distributed test (cherry picked from commit d3bc329)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix buildbot failure #21818 (comment)
A bit of a mystery as to how Linux CI passed correctly.....