Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

download with powershell 2.0 for windows #21968

Closed
wants to merge 7 commits into from
Closed

download with powershell 2.0 for windows #21968

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a909b64
Use powershell for download function for Windows
musm May 19, 2017
64cb9ae
Move global downloadcmd to non windows branch
musm Jun 2, 2017
6f215f7
set downloadcmd to powershell
musm Jun 26, 2017
d5616eb
whites fix
musm Jun 26, 2017
2976fb7
Merge branch 'master' into patch-6
musm Jul 15, 2017
33b582b
Update interactiveutil.jl
musm Jul 15, 2017
569d69a
Update download.jl
musm Jul 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
whites fix
  • Loading branch information
@musm
musm committed Jun 26, 2017
commit d5616eb998ed050c71212b5748a6a642a0ce0e34
1 change: 1 addition & 0 deletions base/interactiveutil.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,6 +567,7 @@ function methodswith(t::Type, showparents::Bool=false)
end

# file downloading

downloadcmd = nothing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may as well set this, if a command is being used

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think downloadcmd can be removed and just be a local variable.
However this is unrelated to the changes in this PR. Let's save this for a separate PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure on a good way to avoid the global here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're changing the download function to shell out to something, the value of what you're shelling out to should be saved in the global that exists for that purpose

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't think this should be moved

if is_windows()
downloadcmd = :powershell
Expand Down