Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make exp(::Complex{Irrational}) work #21596

Merged
merged 1 commit into from
Apr 29, 2017
Merged

Make exp(::Complex{Irrational}) work #21596

merged 1 commit into from
Apr 29, 2017

Conversation

giordano
Copy link
Contributor

Addresses #21204.

@TotalVerb
Copy link
Contributor

What exactly is the use case of having Complex(π, π)?

@giordano
Copy link
Contributor Author

giordano commented Apr 27, 2017 •
edited
Loading

See #21204. Anyway, I spotted the issue for Irrationals, but testing equality with zero using iszero is often more efficient than with == zero(x).

@giordano giordano mentioned this pull request Apr 27, 2017
Closed
5 tasks
@ararslan ararslan added domain:complex Complex numbers domain:maths Mathematical functions labels Apr 27, 2017
@StefanKarpinski StefanKarpinski modified the milestone: 0.6.0 Apr 27, 2017
@JeffBezanson
Copy link
Sponsor Member

LGTM?

@tkelman tkelman merged commit a0c1429 into JuliaLang:master Apr 29, 2017
@giordano giordano deleted the exp-complex-irrationals branch July 18, 2020 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
domain:complex Complex numbers domain:maths Mathematical functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@giordano @TotalVerb @JeffBezanson @StefanKarpinski @tkelman @ararslan