Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #16742, document Iterators.filter #21550

Merged
merged 2 commits into from
Apr 26, 2017
Merged

Fix #16742, document Iterators.filter #21550

merged 2 commits into from
Apr 26, 2017

Conversation

TotalVerb
Copy link
Contributor

No description provided.

@ararslan ararslan added domain:collections Data structures holding multiple items, e.g. sets domain:docs This change adds or pertains to documentation labels Apr 25, 2017
ararslan
ararslan approved these changes Apr 25, 2017
View reviewed changes
Copy link
Member

@ararslan ararslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks! FYI I pushed a commit that prefixes the signature with Iterators to avoid confusion with the Base.filter version, and I fixed a minor typo.

@ararslan
Copy link
Member

Hm, something's weird with Travis. I'm going to close and reopen to trigger a new build without overwriting the old logs.

@ararslan ararslan closed this Apr 25, 2017
@ararslan ararslan reopened this Apr 25, 2017
@ararslan ararslan merged commit ba8e3bb into JuliaLang:master Apr 26, 2017
Sacha0
Sacha0 reviewed Apr 26, 2017
View reviewed changes
Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely written! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sacha0 Sacha0 Sacha0 left review comments

@ararslan ararslan ararslan approved these changes

Assignees
No one assigned
Labels
domain:collections Data structures holding multiple items, e.g. sets domain:docs This change adds or pertains to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TotalVerb @ararslan @Sacha0