Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable FFT plan check with FFTW < 3.3.4 #21546

Merged
merged 1 commit into from
Apr 26, 2017
Merged

Disable FFT plan check with FFTW < 3.3.4 #21546

merged 1 commit into from
Apr 26, 2017

Conversation

nalimilan
Copy link
Member

fftw_sprint_plan wasn't available in FFTW 3.3.3. Hence show of a plan in
FFTW 3.3.3 doesn't actually show the plan contents and the test will fail.

This fixes a test failure introduced by #21169 on RHEL/Centos 7 when using system FFTW.

@nalimilan
Disable FFT plan check with FFTW < 3.3.4
779e65f 
fftw_sprint_plan wasn't available in FFTW 3.3.3. Hence show of a plan in
FFTW 3.3.3 doesn't actually show the plan contents and the test will fail.
@nalimilan nalimilan requested a review from stevengj April 25, 2017 12:14
@stevengj
Copy link
Member

LGTM. Travis spawn failure should be unrelated.

@nalimilan
Copy link
Member Author

Thanks! Indeed, the fft test passed, so it doesn't sound worth restarting the build. The error is:

Error in testset spawn:
Error During Test
  Test threw an exception of type InterruptException
  Expression: success(truecmd)
  InterruptException:

@ararslan
Copy link
Member

Yeah, the macOS failure looks like #17626.

@ararslan ararslan added the domain:maths Mathematical functions label Apr 25, 2017
@tkelman tkelman merged commit 6d76c23 into master Apr 26, 2017
@tkelman tkelman deleted the nl/fft branch April 26, 2017 16:41
@tkelman
Copy link
Contributor

tkelman commented Apr 26, 2017

out of curiosity, what does string(p1) return then?

@stevengj
Copy link
Member

It just prints the type and size of the transform

@tkelman
Copy link
Contributor

tkelman commented May 2, 2017

needs to be backported if #21169 gets backported, right?

@stevengj
Copy link
Member

stevengj commented May 2, 2017

Yes.

tkelman pushed a commit that referenced this pull request May 3, 2017
@nalimilan @tkelman
Disable FFT plan check with FFTW < 3.3.4 (#21546)
bb726db 
fftw_sprint_plan wasn't available in FFTW 3.3.3. Hence show of a plan in
FFTW 3.3.3 doesn't actually show the plan contents and the test will fail.
(cherry picked from commit 6d76c23)
@EthanAnderes EthanAnderes mentioned this pull request Oct 1, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengj stevengj stevengj approved these changes

Assignees
No one assigned
Labels
domain:maths Mathematical functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nalimilan @stevengj @ararslan @tkelman