Misc changes to where syntax plus other clean ups #21487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabloferz
reviewed
Apr 22, 2017
base/abstractarray.jl
Outdated
| @@ -60,7 +60,7 @@ end | |||
| # Performance optimization: get rid of a branch on `d` in `indices(A, | |||
| # d)` for d=1. 1d arrays are heavily used, and the first dimension | |||
| # comes up in other applications. | |||
| indices1{T}(A::AbstractArray{T,0}) = OneTo(1) | |||
| indices1(A::AbstractArray{T,0}) where {T} = OneTo(1) | |||
There was a problem hiding this comment.
Given this is not using T, this could be indices1(A::AbstractArray{<:Any,0}) = OneTo(1)
pabloferz
reviewed
Apr 22, 2017
base/sharedarray.jl
Outdated
| @@ -148,7 +148,7 @@ end | |||
| SharedArray{T,3}(m, n, o; kwargs...) | |||
|
|
|||
| function (::Type{SharedArray{T,N}})(filename::AbstractString, dims::NTuple{N,Int}, | |||
| offset::Integer=0; mode=nothing, init=false, pids::Vector{Int}=Int[]) where T where N | |||
| offset::Integer=0; mode=nothing, init=false, pids::Vector{Int}=Int[]) where T where N | |||
musm
commented
Apr 22, 2017
base/abstractarray.jl
Outdated
| @@ -340,7 +340,7 @@ function checkbounds(::Type{Bool}, A::AbstractArray, i) | |||
| checkindex(Bool, linearindices(A), i) | |||
| end | |||
| # As a special extension, allow using logical arrays that match the source array exactly | |||
| function checkbounds{_,N}(::Type{Bool}, A::AbstractArray{_,N}, I::AbstractArray{Bool,N}) | |||
| function checkbounds(::Type{Bool}, A::AbstractArray{_,N}, I::AbstractArray{Bool,N}) where {_,N} | |||
There was a problem hiding this comment.
would this be better as
function checkbounds(::Type{Bool}, A::AbstractArray{<:Any,N}, I::AbstractArray{Bool,N}) where N
or are those different? @pabloferz
There was a problem hiding this comment.
They are the same and I like the <:Any better that the _ so if you feel like changing it, go for it!
tkelman
reviewed
Apr 22, 2017
base/sharedarray.jl
Outdated
| @@ -148,7 +148,7 @@ end | |||
| SharedArray{T,3}(m, n, o; kwargs...) | |||
|
|
|||
| function (::Type{SharedArray{T,N}})(filename::AbstractString, dims::NTuple{N,Int}, | |||
| offset::Integer=0; mode=nothing, init=false, pids::Vector{Int}=Int[]) where T where N | |||
| offset::Integer=0; mode=nothing, init=false, pids::Vector{Int}=Int[]) where {T,N} | |||
There was a problem hiding this comment.
maybe move offset to the previous line
|
this will need a squash |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.