fix #21397, Nullable(Tuple) method error
#21407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
approved these changes
Apr 16, 2017
test/core.jl
Outdated
| @@ -4820,3 +4820,8 @@ f21271() = convert(Tuple{Type{Int}, Type{Float64}}, (Int, Float64))::Tuple{Type{ | |||
| f21271(x) = x::Tuple{Type{Int}, Type{Float64}} | |||
| @test_throws TypeError f21271() | |||
| @test_throws TypeError f21271((Int, Float64)) | |||
|
|
|||
| # issue #21397 | |||
| bar21397(x::T) where T = T | |||
This was caused by widening a signature in `jl_is_cacheable_sig` such that we ended up calling a specialization containing an unknown static parameter value. This failed when the specialization was created by inference, since it correctly stored a typevar as the value of the static parameter. However when the specialization was created by the method caching logic it accidentally worked, since the static parameter value was derived before widening.
e05605e
to
8b287ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.