Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Immediately expand JULIAHOME in Makefile #21140

Merged
merged 1 commit into from
Mar 23, 2017
Merged

Immediately expand JULIAHOME in Makefile #21140

merged 1 commit into from
Mar 23, 2017

Conversation

staticfloat
Copy link
Sponsor Member

@staticfloat staticfloat commented Mar 23, 2017 •
edited
Loading

This fixes part one of #21137

The size of my patches is starting to get pretty small. Next up: replace a single character with the smallest possible hamming distance to truly attain the smallest possible diff.

@staticfloat staticfloat mentioned this pull request Mar 23, 2017
Closed
@ararslan ararslan added the domain:building Build system, or building Julia or its dependencies label Mar 23, 2017
@vtjnash
Copy link
Sponsor Member

vtjnash commented Mar 23, 2017

dup #20535?

@GunnarFarneback
Copy link
Contributor

This fix has previously been seen in at least #18294, #18447 and #20535. Maybe being completely untangled from anything else can finally get it merged.

@ihnorton ihnorton merged commit 2a5b3d8 into master Mar 23, 2017
@ihnorton ihnorton deleted the sf/single_byte_diff branch March 23, 2017 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ararslan ararslan ararslan approved these changes

Assignees
No one assigned
Labels
domain:building Build system, or building Julia or its dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@staticfloat @vtjnash @GunnarFarneback @ararslan @ihnorton