Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct error message when adding/removing processes from workers #21033

Merged
merged 1 commit into from
Mar 16, 2017
Merged

Correct error message when adding/removing processes from workers #21033

merged 1 commit into from
Mar 16, 2017

Conversation

amitmurthy
Copy link
Contributor

Closes #20742

@ararslan ararslan added domain:error handling Handling of exceptions by Julia or the user domain:parallelism Parallel or distributed computation labels Mar 15, 2017
@amitmurthy amitmurthy merged commit 102800a into master Mar 16, 2017
@amitmurthy amitmurthy deleted the amitm/remoteaddp branch March 16, 2017 05:46
tkelman
tkelman reviewed Mar 16, 2017
View reviewed changes
test/distributed_exec.jl
# Test addprocs/rmprocs from master node only
for f in [ ()->addprocs(1), ()->rmprocs(workers()) ]
try
remotecall_fetch(f, id_other)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs an error("unexpected") otherwise it'll silently do nothing if it succeeds

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. good catch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it in #21059

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

tkelman added a commit to tkelman/julia that referenced this pull request Mar 16, 2017
@tkelman
make sure the test added in JuliaLang#21033 won't silently do nothing
eef873b 
if the remotecall_fetch does not error
ajkeller34 pushed a commit to ajkeller34/julia that referenced this pull request Mar 19, 2017
@amitmurthy @ajkeller34
Correct error message when adding/removing processes from workers (Ju…
defff6a 
…liaLang#21033)
tkelman added a commit to tkelman/julia that referenced this pull request Mar 19, 2017
@tkelman
make sure the test added in JuliaLang#21033 won't silently do nothing
89ea865 
if the remotecall_fetch does not error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkelman tkelman tkelman left review comments

Assignees
No one assigned
Labels
domain:error handling Handling of exceptions by Julia or the user domain:parallelism Parallel or distributed computation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amitmurthy @tkelman @ararslan