Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport openblas patch to fix compilation of assembly with clang 3.9 #20842

Merged
merged 1 commit into from
Mar 1, 2017
Merged

Backport openblas patch to fix compilation of assembly with clang 3.9 #20842

merged 1 commit into from
Mar 1, 2017

Conversation

tkelman
Copy link
Contributor

@tkelman tkelman commented Feb 28, 2017 •
edited
Loading

this version should avoid breaking the mac build

ref #20806, re-fixes #18619

@tkelman
Backport openblas patch to fix compilation of assembly with clang 3.9
ebe7364 
this version should avoid breaking the mac build
@tkelman tkelman added domain:building Build system, or building Julia or its dependencies kind:upstream The issue is with an upstream dependency, e.g. LLVM labels Feb 28, 2017
@tkelman tkelman requested a review from maleadt March 1, 2017 05:06
maleadt
maleadt approved these changes Mar 1, 2017
View reviewed changes
Copy link
Member

@maleadt maleadt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine on my x86-64/Linux system, thanks.

@tkelman tkelman merged commit c716e63 into master Mar 1, 2017
@tkelman tkelman deleted the tk/patch-openblas-clang-asmbug branch March 1, 2017 18:29
@tkelman tkelman mentioned this pull request May 4, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maleadt maleadt maleadt approved these changes

Assignees
No one assigned
Labels
domain:building Build system, or building Julia or its dependencies kind:upstream The issue is with an upstream dependency, e.g. LLVM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Julia does not build with clang 3.9
2 participants
@tkelman @maleadt