Revamp libgit2 owner interface. #20786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that some objects can be owned by non-repo objects. This makes the code a bit more general to allow for this.
| @@ -48,7 +48,7 @@ function Base.sort!(w::GitRevWalker; by::Cint = Consts.SORT_NONE, rev::Bool=fals | |||
| return w | |||
| end | |||
|
|
|||
| repository(w::GitRevWalker) = w.repo | |||
| repository(w::GitRevWalker) = w.owner | |||
There was a problem hiding this comment.
Asking for a repository and getting something else seems a bit iffy.
There was a problem hiding this comment.
Although, I guess for GitRevWalker you know that the owner is a repository?
There was a problem hiding this comment.
exactly, it was just a field rename
StefanKarpinski
approved these changes
Feb 24, 2017
…unnecessary repo arguments
kshyatt
reviewed
Feb 24, 2017
| @@ -53,15 +50,16 @@ function Base.getindex(tree::GitTree, i::Integer) | |||
| te_ptr = ccall((:git_tree_entry_byindex, :libgit2), | |||
| Ptr{Void}, | |||
| (Ptr{Void}, Csize_t), tree.ptr, i-1) | |||
| return GitTreeEntry(te_ptr, false) | |||
| return GitTreeEntry(tree, te_ptr, false) | |||
kshyatt
approved these changes
Feb 24, 2017
StefanKarpinski
approved these changes
Feb 25, 2017
|
does PkgDev rely on any of these things that are being renamed or changing api? |
|
I don't think so, these should all be internal changes.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that some objects can be owned by non-repo objects. This makes the code a bit more general to allow for this.