a bunch of random doctests #20608
a bunch of random doctests #20608
Conversation
KristofferC
added
domain:docs
| julia> iob64_decode = Base64DecodePipe(io); | ||
|
|
||
| julia> write(io, "SGVsbG8h") | ||
| 0x0000000000000008 |
There was a problem hiding this comment.
strange that the return type is inconsistent for write
There was a problem hiding this comment.
Is it? Inconsistent with what?
There was a problem hiding this comment.
write on the Base64EncodePipe above returns signed
There was a problem hiding this comment.
Ah, interesting.
There was a problem hiding this comment.
Could make this an Int
Line 325 in 769d37b
base/cartesian.jl
Outdated
| @@ -13,22 +13,22 @@ export @nloops, @nref, @ncall, @nexprs, @nextract, @nall, @nany, @ntuple, @nif | |||
|
|
|||
| Generate `N` nested loops, using `itersym` as the prefix for the iteration variables. | |||
| `rangeexpr` may be an anonymous-function expression, or a simple symbol `var` in which case | |||
| the range is `1:size(var,d)` for dimension `d`. | |||
| the range is `1:indices(var, d)` for dimension `d`. | |||
There was a problem hiding this comment.
isn't indices itself a range?
There was a problem hiding this comment.
Yes, should just be indices(var, d).
| 2.18425e-314 2.18425e-314 2.18425e-314 2.18425e-314 | ||
| 2.18425e-314 2.18425e-314 2.18425e-314 2.18425e-314 | ||
| ```julia | ||
| julia> similar(falses(10), Float64, 2, 4) |
There was a problem hiding this comment.
Will we always get the same (tiny) numbers for this?
There was a problem hiding this comment.
it will depend on uninitialized memory but it's a ```julia block, not a ```jldoctest
| @@ -281,6 +283,25 @@ getindex(v::SimpleVector, I::AbstractArray) = Core.svec(Any[ v[i] for i in I ].. | |||
|
|
|||
| Tests whether the given array has a value associated with index `i`. Returns `false` | |||
| if the index is out of bounds, or has an undefined reference. | |||
|
|
|||
| ```jldoctest | |||
There was a problem hiding this comment.
do we want to use rand here? I guess it doesn't really matter because you never look at the values but as a style thing...
There was a problem hiding this comment.
Is it bad style with rand? What would you suggest changing it to? ones?
There was a problem hiding this comment.
I think rand is used on other places as well.
|
@kshyatt Can you merge if all ok? |
base/essentials.jl
Outdated
| julia> isassigned(rand(3, 3), 3 * 3 + 1) | ||
| false | ||
|
|
||
| julia> type Foo end |
There was a problem hiding this comment.
Wops, indeed!
Also fixes up some previous buggy doctests (by me), the printing and line numbers.
All doctests now pass again.