Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Notepad++ support for @edit #20416

Merged
merged 1 commit into from
Feb 6, 2017
Merged

Add Notepad++ support for @edit #20416

merged 1 commit into from
Feb 6, 2017

Conversation

GregPlowman
Copy link
Contributor

Issue #20366

I don't really know how to do a pull request or use GitHub.
I'm also not sure how to test this.
I did test on my local machine by overwriting edit() , then just manually copied changed code into GitHub.

@StefanKarpinski
Copy link
Sponsor Member

Hah, ok. Can someone with Notepad++ and the ability to build this PR test this locally? Looks ok...

@ararslan ararslan added the system:windows Affects only Windows label Feb 5, 2017
@hustf
Copy link

hustf commented Feb 5, 2017

Use name= uppercase( .. ) ? This applies to the other editors too I suppose.

@hustf
Copy link

hustf commented Feb 5, 2017

Tested in repl and 0.6.0-dev.2430. This goes in to .juliarc now. Thanks from a long suffering windows user. I do not have the opportunity to build.

@StefanKarpinski StefanKarpinski merged commit 06e22b8 into JuliaLang:master Feb 6, 2017
@GregPlowman GregPlowman deleted the GregPlowman-patch-1 branch February 6, 2017 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system:windows Affects only Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants