add promote rule for Float16 with irrational #20177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1001,3 +1001,7 @@ end | |||
|
|
|||
| # no domain error is thrown for negative values | |||
| @test invoke(cbrt, Tuple{AbstractFloat}, -1.0) == -1.0 | |||
|
|
|||
| @testset "promote Float16 irrational" begin | |||
There was a problem hiding this comment.
Add a reference to #15359 here?
|
updated with ref to #15359, (remember to remove ci skip on merge) |
vchuravy
approved these changes
Jan 23, 2017
There was a problem hiding this comment.
Test failure on AppVeyor seems unrelated (a StackOverflow with summarysize e.g. #19707)
Some tests did not pass: 1279507 passed, 0 failed, 1 errored, 0 broken.misc: Error During Test
Test threw an exception of type StackOverflowError
Expression: $(Expr(:escape, :(summarysize(Core)))) $(Expr(:escape, :>)) $(Expr(:escape, :(summarysize(Core.Inference)))) $(Expr(:escape, :>)) $(Expr(:escape, :(Core.sizeof(Core))))
StackOverflowError:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15359