Fix #20108 fix #20111: method display errors #20119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can we test these under a fake repl output, if the corner cases only happen in interactive display? |
ararslan
added
domain:display and printing
JeffBezanson
previously requested changes
Jan 20, 2017
| @@ -515,6 +515,7 @@ function show_method_candidates(io::IO, ex::MethodError, kwargs::Vector=Any[]) | |||
| # If the methods args is longer than input then the method | |||
| # arguments is printed as not a match | |||
| for (k, sigtype) in enumerate(sig[length(t_i)+1:end]) | |||
| sigtype = unwrap_unionall(sigtype) | |||
There was a problem hiding this comment.
I think this should only be done in the isvarargtype case. Otherwise we won't correctly show argument types that are UnionAlls.
This code also doesn't seem to handle arguments written as ::Vararg{T,N}, but that's a separate pre-existing issue.
ihnorton
force-pushed
the
fixes_20108_20111
branch
from
9f18635
to
6840e75
Compare
|
Updated. Added tests. |
tkelman
reviewed
Jan 21, 2017
| # Issue 20111 | ||
| let K20111(x) = y -> x, buf = IOBuffer() | ||
| show(buf, methods(K20111(1))) | ||
| @test contains(String(buf), " 1 method for generic function") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both errors from trying to access fields of
::UnionAllobjects.replutil seems to be reasonably well-tested already, but hit some corner cases here.