Convert BLAS tests to use testsets #19820
Conversation
kshyatt
added
domain:linear algebra
| if elty == Complex64 || elty == Complex128 | ||
| U = complex.(U, U) | ||
| V = complex.(V, V) | ||
| @testset "syr2k! and her2k!" begin |
There was a problem hiding this comment.
I think we'd get more informative errors if you keep the separation of syr2k and her2k, pull the for loop into the @testset (instead of using begin), and interpolate $elty into the string.
| @test tril(LinAlg.BLAS.her2k('L','N',U,V)) ≈ tril(U*V' + V*U') | ||
| @test triu(LinAlg.BLAS.her2k('U','N',U,V)) ≈ triu(U*V' + V*U') | ||
| @test tril(LinAlg.BLAS.her2k('L','C',U,V)) ≈ tril(U'*V + V'*U) | ||
| @test triu(LinAlg.BLAS.her2k('U','C',U,V)) ≈ triu(U'*V + V'*U) | ||
| end | ||
|
|
||
| ## BLAS tests - testing the interface code to BLAS routines |
There was a problem hiding this comment.
Making this for loop a @testset and putting the elty in the test string will make it easier to locate the error.
| @@ -51,252 +52,261 @@ for elty in [Float32, Float64, Complex64, Complex128] | |||
| v41 = convert(Vector{elty}, [4:-1:1;]) | |||
|
|
|||
| let n = 10 | |||
There was a problem hiding this comment.
Unrelated, but let doesn't seem necessary anymore.
| if elty <: Real | ||
| x1 = convert(Vector{elty}, randn(n)) | ||
| x2 = convert(Vector{elty}, randn(n)) | ||
| α = rand(elty) |
There was a problem hiding this comment.
why is this indented an extra level?
| A = rand(elty,n,n) | ||
| Aherm = A + A' | ||
| Asymm = A + A.' | ||
| @testset "symv and hemv" begin | ||
|
|
There was a problem hiding this comment.
avoid blank line right after begin
|
Did I get everything? Is that test fail my fault? |
|
This looks like #19792 |
| @testset "axpy" begin | ||
| if elty <: Real | ||
| x1 = convert(Vector{elty}, randn(n)) | ||
| x2 = convert(Vector{elty}, randn(n)) | ||
| α = rand(elty) |
There was a problem hiding this comment.
this alpha could've been reused for both Real and non-Real elty, not that it makes too much difference
No description provided.