Add 3 LLVM patches to fix issue #19792 #19810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note this doesn't address the likely test-system bug from #19792 (comment), so we will probably miss more of these going forward until we figure out what's up there. |
tkelman
commented
Jan 2, 2017
| Author: Keno Fischer <[email protected]> | ||
| Date: Mon Jan 2 03:00:19 2017 +0000 | ||
|
|
||
| Reapply "[CodeGen] Fix invalid DWARF info on Win64" |
There was a problem hiding this comment.
whoops this doesn't actually apply cleanly against 3.9.1
miscompilation of broadcast
tkelman
force-pushed
the
tk/llvm-patches
branch
from
bf92182
to
b4939da
Compare
tkelman
force-pushed
the
tk/llvm-patches
branch
from
0630e78
to
98d7406
Compare
so FreeBSD patch handles it better
tkelman
force-pushed
the
tk/llvm-patches
branch
from
98d7406
to
d02ecaf
Compare
|
Patch D27389 does not seem to apply to 3.9.1 with |
|
LLVM 3.9 builds on FreeBSD on this branch, so I'd say this fixes #19769. |
tkelman
force-pushed
the
tk/llvm-patches
branch
from
f891b81
to
c2946bd
Compare
tkelman
changed the title
tkelman
commented
Jan 4, 2017
| - *Type = INTEL_COREI7; // "skylake" | ||
| - *Subtype = INTEL_COREI7_SKYLAKE; | ||
| + *Type = INTEL_COREI7; | ||
| + if (Features & (1 << FEATURE_AVX512)) { |
There was a problem hiding this comment.
oops, looks like this had some review upstream and changed - will rebuild again
tkelman
force-pushed
the
tk/llvm-patches
branch
from
c2946bd
to
5f265f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
miscompilation of broadcast
Will need to rebuild the windows binaries for appveyor before merging this, and the homebrew-julia llvm39 formula whenever. If you have any other LLVM patches in mind, do speak up so I can rebuild things fewer times.
fixes #19792, fixes #19769