Update CONTRIBUTING.md #19440
Merged
Update CONTRIBUTING.md #19440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"mailing list" -> Discourse
nalimilan
reviewed
Nov 28, 2016
| @@ -12,7 +12,7 @@ Hi! If you are new to the Julia community: welcome, and thanks for trying Julia. | |||
|
|
|||
| - Contributing code? Be sure to review the [contributor checklist](https://github.com/JuliaLang/julia/blob/master/CONTRIBUTING.md#contributor-checklist) for helpful tips on the tools we use to build Julia. | |||
|
|
|||
| - Library feature requests are generally not accepted on this issue tracker. New libraries should be developed as [packages](https://docs.julialang.org/en/release-0.4/manual/packages/#package-development). Please email the [julia-users](https://groups.google.com/forum/#!forum/julia-users) mailing list to discuss library ideas. Doing so will often lead to pointers to existing projects and bring together collaborators with common interests. | |||
| - Library feature requests are generally not accepted on this issue tracker. New libraries should be developed as [packages](https://docs.julialang.org/en/release-0.4/manual/packages/#package-development). Discuss ideas for libraries at [Julia Discourse forum](https://discourse.julialang.org/). Doing so will often lead to pointers to existing projects and bring together collaborators with common interests. | |||
There was a problem hiding this comment.
Not a native speaker, but maybe "the Julia Discourse forum"?
insert "the"
nalimilan
approved these changes
Nov 28, 2016
vchuravy
approved these changes
Nov 28, 2016
| @@ -12,7 +12,7 @@ Hi! If you are new to the Julia community: welcome, and thanks for trying Julia. | |||
|
|
|||
| - Contributing code? Be sure to review the [contributor checklist](https://github.com/JuliaLang/julia/blob/master/CONTRIBUTING.md#contributor-checklist) for helpful tips on the tools we use to build Julia. | |||
|
|
|||
| - Library feature requests are generally not accepted on this issue tracker. New libraries should be developed as [packages](https://docs.julialang.org/en/release-0.4/manual/packages/#package-development). Please email the [julia-users](https://groups.google.com/forum/#!forum/julia-users) mailing list to discuss library ideas. Doing so will often lead to pointers to existing projects and bring together collaborators with common interests. | |||
| - Library feature requests are generally not accepted on this issue tracker. New libraries should be developed as [packages](https://docs.julialang.org/en/release-0.4/manual/packages/#package-development). Discuss ideas for libraries at the [Julia Discourse forum](https://discourse.julialang.org/). Doing so will often lead to pointers to existing projects and bring together collaborators with common interests. | |||
There was a problem hiding this comment.
Also not a native speaker, but I would write "on the"
| @@ -240,7 +240,7 @@ Make sure that [Travis](https://www.travis-ci.org) greenlights the pull request w | |||
|
|
|||
| * Julia | |||
| - **Homepage:** <https://julialang.org> | |||
| - **Mailing lists:** <https://julialang.org/community/> | |||
| - **Discussion:** <https://julialang.org/community/> | |||
There was a problem hiding this comment.
Maybe simply call it Community, since neither Mailing lists nor Discussion is quite right
"Discussion" -> "Community"
|
Thanks! |
fcard
pushed a commit
to fcard/julia
that referenced
this pull request
Feb 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"mailing list" -> Discourse