Patch OpenBLAS to build on FreeBSD #19356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticfloat
approved these changes
Nov 17, 2016
There was a problem hiding this comment.
Looks good to me, except that I would put a comment next to the patch with a link to OpenMathLib/OpenBLAS#1015 saying that this patch can be removed once a release including your fix is merged.
|
Good idea. I should do that for the LibSSH2 patch as well. |
|
A now a bump for my last outstanding FreeBSD PR. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a minimal patch to OpenBLAS that allows it to build on FreeBSD. The issue was that certain header files weren't being included because FreeBSD was omitted from the OS conditional that includes them. The change should have no effect at all on other systems.
The patch has been submitted upstream: OpenMathLib/OpenBLAS#1015