make isfile_casesensitive only check case of the basename on Windows #19291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… consistent with other platforms
tkelman
reviewed
Nov 10, 2016
| @test !Base.isfile_casesensitive(lowered_filename) | ||
| rm(true_filename) | ||
| end | ||
| cd(mktempdir()) do |
There was a problem hiding this comment.
use nested do blocks so the mktempdir also gets cleaned up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the
Base.isfile_casesensitivefunction of #13542, which is used to implement a case-sensitiverequire(forusingandimport) to only check the case of thebasenameof the path on Windows. Rationale:This is consistent with what is done on MacOS and in the fallback (
readdir-based) routine.This way, the
usingstatement is case-sensitive, but things likeLOAD_PATHare not, as one would probably expect on a case-insensitive filesystem. (See also this discussion.)Also relevant for #18210. cc @malmaud and @jakebolewski.