Rename num/den to numerator/denominator #19246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanKarpinski
requested changes
Nov 7, 2016
|
@StefanKarpinski Link to issue or PR? Seems like all entries in |
|
I don't think it really matters which as long as there's an entry and a trail of breadcrumbs. |
StefanKarpinski
approved these changes
Nov 7, 2016
|
I don't have the power of the button, but I think this is all done? |
|
LGTM |
nalimilan
reviewed
Nov 9, 2016
| @@ -66,6 +66,8 @@ Deprecated or removed | |||
|
|
|||
| * `is` has been deprecated in favor of `===` (which used to be an alias for `is`) ([#17758]). | |||
|
|
|||
| * `num` and `den` has been deprecated in favor of `numerator` and `denominator` respectively ([#19233]). | |||
|
There seems to be a modicum of disagreement on the original issue, so let's that discussion play out before merging this. |
|
I think that discussion is resolved in favor of the change. Merge? |
|
Argh, I think I left the CI skip message in the squash merge. Sorry :/ |
|
Not your fault: controlling the CI tools via commit messages is an incredibly dumb, bad UX design. |
fcard
pushed a commit
to fcard/julia
that referenced
this pull request
Feb 28, 2017
* rename num/den -> numerator/denominator * added news entry [ci skip] * grammar [ci skip]
Sacha0
added a commit
to Sacha0/julia
that referenced
this pull request
May 18, 2017
Sacha0
added a commit
to Sacha0/julia
that referenced
this pull request
May 18, 2017
ararslan
pushed a commit
that referenced
this pull request
May 18, 2017
tkelman
pushed a commit
that referenced
this pull request
Jun 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #19233
Think I found all the places. Also moved docstrings inline.