Add module name to method show output #19162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanKarpinski
approved these changes
Oct 31, 2016
|
I like it. |
fcard
pushed a commit
to fcard/julia
that referenced
this pull request
Feb 28, 2017
* Add the method's module name to the show output * Update tests that involve showing a method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up in the discussion over in #18745. The general point of the issue was that it is hard to find where things are defined.
While
whichwill tell you the module in which a generic function was defined, there didn't seem to be an easy way to find the module in which a specific method was defined. This pull request adds the module name to the method show output. For example:There will probably be a few different changes proposed out of that issue. This was just an easy one to start with (assuming people like it).