Add Windows patches for LLVM 3.9 #19138

tkelman · 2016-10-27T23:30:44Z

part of #19123

threads patch was rebased on rust's llvm fork
rust-lang/llvm@d1cc489

cygwin build patch is from llvm-mirror/llvm@9f79578
in cross-compile, a subset of llvm gets built for the native build system

This crashes at the start of bootstrap on both win64:

    JULIA usr/lib/julia/inference.ji

This application has requested the Runtime to terminate it in an unusual way.
Please contact the application's support team for more information.
Assertion failed!

Program: C:\cygwin64\home\Tony\julia\usr\bin\julia.exe
File: /home/Tony/julia/src/codegen.cpp, Line 1149

Expression: fptr.fptr != NULL
make[1]: *** [Makefile:217: /home/Tony/julia/usr/lib/julia/inference.ji] Error 3
make: *** [Makefile:96: julia-inference] Error 2

and win32:

    JULIA usr/lib/julia/inference.ji
LLVM ERROR: Program used external function '_memset' which could not be resolved!
make[1]: *** [Makefile:217: /home/Tony/julia32/usr/lib/julia/inference.ji] Error 1
make: *** [Makefile:96: julia-inference] Error 2

threads patch was rebased on rust's llvm fork rust-lang/llvm@d1cc489 cygwin build patch is from llvm-mirror/llvm@9f79578 in cross-compile, a subset of llvm gets built for the native build system

tkelman · 2016-10-28T00:37:48Z

@vtjnash I'll need you to check that I rebased 7ee818c right. We also need to write an LLVM unit test for that so we can get it upstreamed.

(did not help with the assertion/external function failure on bootstrap though)

tkelman · 2016-10-28T17:15:33Z

Note to self: should look into whether we need https://github.com/cygwinports/llvm/blob/598b7d8c704f2c8e59daddde1900318aef9eed72/0003-Fix-RuntimeDyldCOFFI386-to-handle-relocations-with-a.patch

vtjnash · 2016-10-29T05:02:29Z

We don't need it, as we don't use that code path. Could be interesting to look into though at some point, now that we know that code path might work.

vchuravy · 2016-11-25T03:10:46Z

I tried to look into this:

Rebased this branch and added patch to copy missing winpthread-1
Building on Windows 10 Cygwin + Mingw64 5.4.0
Branch is vc/win-fixes

Debug on Win64

    LINK usr/bin/julia-debug.exe
    JULIA usr/lib/julia/inference.ji
LLVM ERROR: Program used external function '__security_check_cookie' which could not be resolved!
make[1]: *** [Makefile:217: /home/valentin-churavy/julia/usr/lib/julia/inference.ji] Error 1
make: *** [Makefile:96: julia-inference] Error

The lowering for that is In lib/Target/X86/X86ISelLowering.cpp around line 1994, which is guarded by a check to Subtarget.getTargetTriple().isOSMSVCRT(). Added in D20346.
We either have to load the MSVC bufferoverflowu.lib or change the SubTarget to not be MSVC.

Win64:

$ make
    JULIA usr/lib/julia/inference.ji
/bin/sh: line 1:  6560 Segmentation fault      /home/valentin-churavy/julia/usr/bin/julia.exe -C native --output-ji `cygpath -w /home/valentin-churavy/julia/usr/lib/julia/inference.ji` --startup-file=no -g0 -O0 coreimg.jl
make[1]: *** [Makefile:217: /home/valentin-churavy/julia/usr/lib/julia/inference.ji] Error 139
make: *** [Makefile:96: julia-inference] Error 2

Program received signal SIGSEGV, Segmentation fault.
0x0000000000000000 in ?? ()
(gdb) set $pc = *(void **)$esp
(gdb) set $esp = $esp + 4
(gdb) bt
#0  0x000000006c292b9d in jl_call_method_internal (meth=0x100f8d630, args=0xc6d6a0, nargs=2) at /home/valentin-churavy/julia/src/julia_internal.h:239
#1  0x000000006c298e0e in jl_apply_generic (args=0xc6d6a0, nargs=2) at /home/valentin-churavy/julia/src/gf.c:1861
#2  0x000000006c2ae22c in do_call (args=0x100f8d0d0, nargs=2, s=0x0) at /home/valentin-churavy/julia/src/interpreter.c:71
#3  0x000000006c2aed7a in eval (e=0x100f86df0, s=0x0) at /home/valentin-churavy/julia/src/interpreter.c:210
#4  0x000000006c2ae208 in do_call (args=0x100f8d070, nargs=2, s=0x0) at /home/valentin-churavy/julia/src/interpreter.c:70
#5  0x000000006c2aed7a in eval (e=0x100f86dd0, s=0x0) at /home/valentin-churavy/julia/src/interpreter.c:210
#6  0x000000006c2ae208 in do_call (args=0x100f8acf0, nargs=3, s=0x0) at /home/valentin-churavy/julia/src/interpreter.c:70
#7  0x000000006c2aed7a in eval (e=0x100f86db0, s=0x0) at /home/valentin-churavy/julia/src/interpreter.c:210
#8  0x000000006c2af206 in eval (e=0x100f86d90, s=0x0) at /home/valentin-churavy/julia/src/interpreter.c:267
#9  0x000000006c2b081e in eval_body (stmts=0x100f8abd0, s=0x0, start=0, toplevel=1) at /home/valentin-churavy/julia/src/interpreter.c:549
#10 0x000000006c2b0260 in jl_toplevel_eval_body (stmts=0x100f8abd0) at /home/valentin-churavy/julia/src/interpreter.c:456
#11 0x000000006c2d2ae1 in jl_toplevel_eval_flex (e=0x100f86d50, fast=1, expanded=1) at /home/valentin-churavy/julia/src/toplevel.c:622
#12 0x000000006c2a20dc in jl_parse_eval_all (fname=0x6c4bc0ec <INEXACT_ENTRY+1124> "boot.jl", content=0x0, contentlen=0) at /home/valentin-churavy/julia/src/ast.c:735
#13 0x000000006c2d2cf0 in jl_load (fname=0x6c4bc0ec <INEXACT_ENTRY+1124> "boot.jl") at /home/valentin-churavy/julia/src/toplevel.c:666
#14 0x000000006c2bb725 in _julia_init (rel=JL_IMAGE_JULIA_HOME) at /home/valentin-churavy/julia/src/init.c:639
#15 0x000000006c2bd827 in julia_init (rel=JL_IMAGE_JULIA_HOME) at /home/valentin-churavy/julia/src/task.c:289
#16 0x000000000040243c in wmain (argc=1, argv=0x407fbd0, envp=0x407e8a0) at /home/valentin-churavy/julia/ui/repl.c:247
#17 0x000000000040140c in __tmainCRTStartup () at /usr/src/debug/mingw64-x86_64-runtime-5.0.0-1/crt/crtexe.c:329
#18 0x000000000040153b in mainCRTStartup () at /usr/src/debug/mingw64-x86_64-runtime-5.0.0-1/crt/crtexe.c:212

tkelman · 2016-11-25T05:36:21Z

GCC 5.4 will most likely still miscompile LLVM (even 3.7) on win32. The GCC 4.9 build from cygwin did not need libwinpthread, but it's not currently easy to get. Probably need to use the cygwin time machine to get the past versions.

vchuravy · 2016-11-25T07:02:29Z

Thanks for the hint with cygwin time machine (2016/09/09-131242 still has 4.9.2)

vchuravy · 2016-11-25T08:37:26Z

Same problem with 4.9.2

(gdb) call jl_(meth)
Core.Typeof(#Typeof, #<null>.Any)
(gdb) p meth.fptr
$1 = (jl_fptr_t) 0x0

vchuravy · 2016-11-28T15:02:15Z

@tkelman The llvm-3.9.0_threads patch seems to be excessively large in comparison to the patch for 3.8.

tkelman · 2016-11-28T15:16:16Z

I took it straight from Rust's fork, didn't think too much about it.

vchuravy · 2016-11-30T02:32:12Z

Restarted appveyor for this. Log is backed up here https://gist.github.com/vchuravy/4b995598e033574c45b7b9f83c4333b1

vchuravy

From my perspective this is ready to be merged

tkelman · 2016-11-30T05:39:29Z

I still haven't looked much at the threads patch, but I think the old copy was doing #if 0 around big chunks of code. Maybe that's not as possible to do cleanly in 3.9 for some reason?

vchuravy · 2016-11-30T06:36:44Z

It seems to remove lli-child-target, llvm-cov, and sancov completely. Maybe these are parts of llvm that rely on the functionality that is disabled? It looks like the patch is turning of `RPCUtils.

Fixes for LLVM 3.9 and Win64

Add two patches so LLVM 3.9 at least builds for Windows

2b4fbdd

threads patch was rebased on rust's llvm fork rust-lang/llvm@d1cc489 cygwin build patch is from llvm-mirror/llvm@9f79578 in cross-compile, a subset of llvm gets built for the native build system

tkelman added the domain:building Build system, or building Julia or its dependencies label Oct 27, 2016

vchuravy mentioned this pull request Oct 27, 2016

Upgrade to LLVM 3.9 #19123

Closed

tkelman added the system:windows Affects only Windows label Oct 27, 2016

tkelman added 2 commits October 27, 2016 20:03

Rebase llvm-win64-reloc-dwarf.patch against 3.9.0

7ee818c

Remove LLVM_LIB_SUFFIX, it is not used any more

dcbe667

tkelman changed the title ~~Add two patches so LLVM 3.9 at least builds for Windows~~ Add Windows patches for LLVM 3.9 Oct 28, 2016

vchuravy mentioned this pull request Nov 29, 2016

Fixes for LLVM 3.9 on Win64 #19446

Closed

vchuravy added 2 commits November 29, 2016 08:24

LLVM debug builds creates big objects

6766776

force ELF with LLVM 3.9

e61118b

vchuravy approved these changes Nov 30, 2016

View reviewed changes

vchuravy and others added 2 commits December 1, 2016 23:04

use libssp instead of MSVCRT implementations

6a1c2b6

Merge pull request #19472 from JuliaLang/vc/ssp

bf012f8

Fixes for LLVM 3.9 and Win64

tkelman merged commit 1e0e793 into master Dec 3, 2016

tkelman deleted the tk/llvmpatches branch December 3, 2016 13:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Windows patches for LLVM 3.9 #19138

Add Windows patches for LLVM 3.9 #19138

tkelman commented Oct 27, 2016

tkelman commented Oct 28, 2016 •

edited

Loading

tkelman commented Oct 28, 2016

vtjnash commented Oct 29, 2016

vchuravy commented Nov 25, 2016 •

edited

Loading

tkelman commented Nov 25, 2016

vchuravy commented Nov 25, 2016

vchuravy commented Nov 25, 2016

vchuravy commented Nov 28, 2016

tkelman commented Nov 28, 2016

vchuravy commented Nov 30, 2016

vchuravy left a comment

tkelman commented Nov 30, 2016

vchuravy commented Nov 30, 2016

Add Windows patches for LLVM 3.9 #19138

Add Windows patches for LLVM 3.9 #19138

Conversation

tkelman commented Oct 27, 2016

tkelman commented Oct 28, 2016 • edited Loading

tkelman commented Oct 28, 2016

vtjnash commented Oct 29, 2016

vchuravy commented Nov 25, 2016 • edited Loading

tkelman commented Nov 25, 2016

vchuravy commented Nov 25, 2016

vchuravy commented Nov 25, 2016

vchuravy commented Nov 28, 2016

tkelman commented Nov 28, 2016

vchuravy commented Nov 30, 2016

vchuravy left a comment

Choose a reason for hiding this comment

tkelman commented Nov 30, 2016

vchuravy commented Nov 30, 2016

tkelman commented Oct 28, 2016 •

edited

Loading

vchuravy commented Nov 25, 2016 •

edited

Loading