Use string parsing for command literals #18644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we give single quotes the same treatment while at it? Figure we can get more use out of them than we're doing right now. |
Let's make that a separate PR instead of holding this up with it. |
stevengj
reviewed
Sep 24, 2016
| (let* ((str (begin (take-token s) | ||
| (parse-string-literal s #t))) | ||
| ;; custom string and command literals; x"s" => @x_str "s" | ||
| (let* ((macstr (begin (take-token s) |
There was a problem hiding this comment.
Shouldn't this be (car (begin ....)) since the previous version of macstr also took the car?
There was a problem hiding this comment.
No; it calls parse-raw-literal which wraps the car call.
|
LGTM. |
|
This has been open for a while, passed CI, thumbs up from a bunch of folks. Going to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes command literals to be parsed the same way (raw) string literals are.
Consequences:
```now supportedxparsing tocmd@x_cmd "cmd"now supported\r\nwithin command literals translated to\n\\within command literals now means two backslashes, instead of one. Note that this means it is no longer possible to end a command literal with a single backslash. I don't think this is a big deal, since it can just be quoted.Cmdconstructor just special-cased it.This implements the less breaking and less controversial (I think) part of #12139.