Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devdocs for bounds checking following #18401 #18552

Merged
merged 1 commit into from
Sep 21, 2016
Merged

Conversation

mbauman
Copy link
Sponsor Member

@mbauman mbauman commented Sep 16, 2016

I had forgotten that this behavior was documented in the developer section of the manual when authoring #18401.

[ci skip]

I had forgotten that this behavior was documented in the developer section of the manual when authoring #18401.

[ci skip]
@tkelman tkelman added domain:docs This change adds or pertains to documentation backport pending 0.5 labels Sep 16, 2016
tkelman pushed a commit that referenced this pull request Sep 17, 2016
Fixes #18271. Allow multidimensional logical arrays as indices into a particular dimension so long as there is only one non-singleton dimension.

(cherry picked from commit 5fa5b7f)
ref #18401

Fixup inline comment

(cherry picked from commit 2bbcd80)

Update devdocs for bounds checking following #18401

I had forgotten that this behavior was documented in the developer section of the manual when authoring #18401.

(cherry picked from commit b8406ff)
ref #18552
@kshyatt kshyatt merged commit 6e9ab0c into master Sep 21, 2016
@kshyatt kshyatt deleted the mb/devdocupdate branch September 21, 2016 03:43
@tkelman
Copy link
Contributor

tkelman commented Feb 15, 2017

since I reverted #18401 on release-0.5 prior to 0.5.0, this isn't relevant any more right?

@mbauman
Copy link
Sponsor Member Author

mbauman commented Feb 15, 2017

Ah, good memory. Yes, checkbounds_logical still exists on 0.5. So this is not backport-worthy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:docs This change adds or pertains to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants