Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compile=all #18430

Merged
merged 1 commit into from
Sep 9, 2016
Merged

fix compile=all #18430

merged 1 commit into from
Sep 9, 2016

Conversation

vtjnash
Copy link
Sponsor Member

@vtjnash vtjnash commented Sep 9, 2016

fix #18080

@tkelman
Copy link
Contributor

tkelman commented Sep 9, 2016

can we test this somehow?

@yuyichao
Copy link
Contributor

yuyichao commented Sep 9, 2016

Get a new CI service working so that we can afford running a CI with compile=all enabled?

@tkelman
Copy link
Contributor

tkelman commented Sep 9, 2016

we have buildbots, can add more

@vtjnash vtjnash merged commit 1e02f7e into master Sep 9, 2016
@vtjnash vtjnash deleted the jn/18080 branch September 9, 2016 22:07
@tkelman tkelman added the needs tests Unit tests are required for this change label Sep 9, 2016
@ViralBShah ViralBShah added this to the 0.5.x milestone Sep 10, 2016
tkelman pushed a commit that referenced this pull request Sep 16, 2016
@vtjnash @tkelman
fix compile=all
2b4c040 
fix #18080

(cherry picked from commit a78ad7b)
ref #18430
@tkelman
Copy link
Contributor

tkelman commented Sep 20, 2016

Still needs to be tested somewhere or it'll regress again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs tests Unit tests are required for this change
Projects
None yet
Milestone
0.5.x
Development

Successfully merging this pull request may close these issues.

Hang generating sys-all.o
4 participants
@vtjnash @tkelman @yuyichao @ViralBShah