recompute sparams during inference after widening a method signature #18428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1089,6 +1089,9 @@ static jl_cgval_t emit_getfield_knownidx(const jl_cgval_t &strct, unsigned idx, | |||
| fieldval.gcroot = strct.gcroot; | |||
| return fieldval; | |||
| } | |||
| else if (isa<UndefValue>(strct.V)) { | |||
| return jl_cgval_t(); | |||
There was a problem hiding this comment.
👍 We might need to do this more consistently in other places too though.
There was a problem hiding this comment.
or more callers need to look at strct.typ instead of exprtype (since exprtype can be wrong / meaningless in dead code)
also avoid an expensive loop in the common case of the hotpath fix #18399
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also avoid an expensive loop in the common case of the hotpath
fix #18399