Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable at-simd warning. #18425

Merged
merged 1 commit into from
Sep 10, 2016
Merged

Disable at-simd warning. #18425

merged 1 commit into from
Sep 10, 2016

Conversation

yuyichao
Copy link
Contributor

@yuyichao yuyichao commented Sep 9, 2016

It's not helpful/annoy for users because,

  1. It doesn't cover the majority of the cases when a loop can't be vectorized (the majority of the cases that matters anyway).
  2. It makes it hard to put @simd on a loop that might be vectorizable without getting the warning for non builtin types.

It's not really helpful for debugging vectorization failure due to codegen issues either since

  1. In it's current state (probably different before), I've never seen a single case captured by it
  2. It doesn't print any useful debug info with it so you need some other ways to print the llvm ir anyway

@yuyichao yuyichao added the compiler:codegen Generation of LLVM IR and native code label Sep 9, 2016
@StefanKarpinski StefanKarpinski added this to the 0.5.x milestone Sep 9, 2016
@kshyatt kshyatt added the domain:broadcast Applying a function over a collection label Sep 9, 2016
@yuyichao
Copy link
Contributor Author

yuyichao commented Sep 9, 2016

I believe the vectorization label is for the matlab-style vectorized array operation, not for vector instruction/loop vectorization.

@yuyichao yuyichao removed the domain:broadcast Applying a function over a collection label Sep 9, 2016
@ArchRobison
Copy link
Contributor

@yuyichao makes a convincing case -- the patch looks good to me.

@yuyichao yuyichao merged commit 843e0fe into master Sep 10, 2016
@yuyichao yuyichao deleted the yyc/codegen/@simd-warn branch September 10, 2016 01:21
@StefanKarpinski
Copy link
Sponsor Member

Should we backport this to 0.5.1? This won't break code in either direction since it's a warning.

tkelman pushed a commit that referenced this pull request Feb 22, 2017
(cherry picked from commit da73b06)
ref #18425
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:codegen Generation of LLVM IR and native code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants