hook up runtime intrinsics #18382
Merged
hook up runtime intrinsics #18382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocator::eraseFunction doesn't delete our global this only comes up if a finalizer runs something that wasn't already compiled which currently apparently doesn't happen on master
and fix runtime setting of intrinsic properties array
| { | ||
| jl_sym_t *sname = jl_symbol(name); | ||
| jl_value_t *f = jl_new_generic_function_with_supertype(sname, jl_core_module, jl_builtin_type, 0); | ||
| if (dt == NULL) { | ||
| jl_value_t *f = jl_new_generic_function_with_supertype(sname, jl_core_module, jl_builtin_type, 0); |
now IntrinsicFunctions works just like any other BuiltinFunction (except for ccall and llvmcall, which don't yet have runtime versions)
vtjnash
force-pushed
the
jn/runtime-intrinsics
branch
from
2e4bd5e
to
8f75347
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This long-overdue PR makes the intrinsic functions work just like normal builtin functions instead of requiring special rules in the compiler.
incorporates parts of jn/jlinterpreter and #14918