Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Ctrl-C in the debugger works again. #18354

Merged
merged 1 commit into from
Sep 6, 2016
Merged

Make Ctrl-C in the debugger works again. #18354

merged 1 commit into from
Sep 6, 2016

Conversation

yuyichao
Copy link
Contributor

@yuyichao yuyichao commented Sep 4, 2016

Turn the SIGINT, which we catch before the debugger, into a SIGTRAP and
decide if the SIGINT should be handled based on whether the SIGTRAP is
handled by the debugger.

static int jl_ignore_sigint(void)
{
// On Unix, we get the SIGINT before the debugger which makes it very
// hard to interrupt a running process in the debugger with `Ctrl-C`.
// Manually raise a `SIGINT` on current thread with the signal temperarily
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

temporarily

@vtjnash
Copy link
Sponsor Member

vtjnash commented Sep 5, 2016

lgtm

Raise a `SIGINT` manually with signal unblocked to see
if debugger is handling it.
@yuyichao yuyichao merged commit 8761c48 into master Sep 6, 2016
@yuyichao yuyichao deleted the yyc/signals/dbg branch September 6, 2016 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants